linux-kernel - Re: [PATCH] x86/speculation: Use AMD specific retpoline for inline asm on AMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Sep 2018 12:59:39 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Zhenzhong Duan <zhenzhong.duan@...cle.com>
Cc:     linux-kernel@...r.kernel.org, mingo@...hat.com,
        konrad.wilk@...cle.com, x86@...nel.org, dwmw@...zon.co.uk,
        tglx@...utronix.de, Srinivas REDDY Eeda <srinivas.eeda@...cle.com>,
        bp@...e.de, hpa@...or.com, dhaval.giani@...cle.com
Subject: Re: [PATCH] x86/speculation: Use AMD specific retpoline for inline
 asm on AMD

On Tue, Sep 18, 2018 at 06:31:07PM +0800, Zhenzhong Duan wrote:
> On 2018/9/18 17:50, Peter Zijlstra wrote:
> > On Mon, Sep 17, 2018 at 10:17:30PM -0700, Zhenzhong Duan wrote:
> > > -#elif defined(CONFIG_X86_32) && defined(CONFIG_RETPOLINE)
> > > +#elif defined(CONFIG_RETPOLINE)
> > 
> > This doesn't make any sense..
> This change is used for x86_64 to have minimal Retpoline support when
> CONFIG_RETPOLINE is defined but RETPOLINE isn't defined, or I missed
> something?

No it doesn't.

#if defined(X86_64) && defined(RETPOLINE)

 /* x86_64 retpoline goes here */

#elif defined(RETPOLINE)

 /* !x86_64 retpoline goes here */

#else

 /* !retpoline goes here

#endif