linux-kernel - Re: [PATCH 2/2] Compiler Attributes: naked can be shared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Sep 2018 09:17:52 -0700
From:   Stefan Agner <stefan@...er.ch>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Eli Friedman <efriedma@...eaurora.org>,
        Christopher Li <sparse@...isli.org>,
        Kees Cook <keescook@...omium.org>,
        Ingo Molnar <mingo@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Joe Perches <joe@...ches.com>,
        Dominique Martinet <asmadeus@...ewreck.org>,
        linux-sparse@...r.kernel.org
Subject: Re: [PATCH 2/2] Compiler Attributes: naked can be shared

On 18.09.2018 09:06, Miguel Ojeda wrote:
> On Tue, Sep 18, 2018 at 9:30 AM, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
>> On Mon, Sep 17, 2018 at 08:19:50PM -0700, Stefan Agner wrote:
>>> On 13.09.2018 16:59, Miguel Ojeda wrote:
>>> > The naked attribute is supported by at least gcc >= 4.6 (for ARM,
>>> > which is the only current user), gcc >= 8 (for x86), clang >= 3.1
>>> > and icc >= 13. See https://godbolt.org/z/350Dyc
>>> >
>>> > Therefore, move it out of compiler-gcc.h so that the definition
>>> > is shared by all compilers.
>>> >
>>> > This also fixes Clang support for ARM32 --- 815f0ddb346c
>>> > ("include/linux/compiler*.h: make compiler-*.h mutually exclusive").
>>> >
>>> > Cc: Stefan Agner <stefan@...er.ch>
>>> > Cc: Rasmus Villemoes <linux@...musvillemoes.dk>
>>> > Cc: Eli Friedman <efriedma@...eaurora.org>
>>> > Cc: Christopher Li <sparse@...isli.org>
>>> > Cc: Kees Cook <keescook@...omium.org>
>>> > Cc: Ingo Molnar <mingo@...nel.org>
>>> > Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
>>> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>>> > Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
>>> > Cc: Joe Perches <joe@...ches.com>
>>> > Cc: Dominique Martinet <asmadeus@...ewreck.org>
>>> > Cc: Linus Torvalds <torvalds@...ux-foundation.org>
>>> > Cc: linux-sparse@...r.kernel.org
>>> > Suggested-by: Arnd Bergmann <arnd@...db.de>
>>> > Reviewed-by: Luc Van Oostenryck <luc.vanoostenryck@...il.com>
>>> > Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>
>>> > Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
>>>
>>> Reviewed-by: Stefan Agner <stefan@...er.ch>
>>>
>>> Ideally this two patches should go into v4.19. Not sure which path the patch should take, MAINTAINERS is not quite clear about that. This fixes 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h mutually exclusive") for ARM32, which has been merged directly by
>>> Linus, afaict...
>>
>> Good point, can you resend these to me with all of the acks added so
>> far?
> 
> Sure (I think only Stefan is the added ack, though).
> 

Thanks Miguel.

You can also add my Tested-by: Stefan Agner <stefan@...er.ch> to the two patches.

--
Stefan

> Cheers,
> Miguel