linux-kernel - Re: [PATCH v2] usb: host: Replace empty define with do while

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 20 Sep 2018 10:24:23 -0400 (EDT)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Corentin Labbe <clabbe@...libre.com>
cc:     gregkh@...uxfoundation.org, <linux-kernel@...r.kernel.org>,
        <linux-usb@...r.kernel.org>, <joe@...ches.com>
Subject: Re: [PATCH v2] usb: host: Replace empty define with do while

On Wed, 19 Sep 2018, Corentin Labbe wrote:

> It's dangerous to use empty code define.
> Furthermore it lead to the following warning:
> "suggest braces around empty body in an « else » statement"
> 
> So let's replace emptyness by "do {} while(0)"
> 
> Furthermore, as suggested by Joe Perches, rename the macro to INCR.
> 
> Signed-off-by: Corentin Labbe <clabbe@...libre.com>
> ---
> Changes since v1:
> - rename the macro from COUNT to INCR

For the EHCI portions:

Acked-by: Alan Stern <stern@...land.harvard.edu>