linux-kernel - Re: [PATCH AUTOSEL 4.18 032/136] arm64: fix infinite stacktrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Sep 2018 14:58:42 +0000
From:   Sasha Levin <Alexander.Levin@...rosoft.com>
To:     Will Deacon <will.deacon@....com>
CC:     Mikulas Patocka <mpatocka@...hat.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH AUTOSEL 4.18 032/136] arm64: fix infinite stacktrace

On Tue, Sep 18, 2018 at 12:00:51PM +0100, Will Deacon wrote:
>On Tue, Sep 18, 2018 at 06:55:34AM -0400, Mikulas Patocka wrote:
>> This patch is not correct, because the stacktrace is supposed to work
>> around discontiguous interrupt stacks.
>>
>> You should replace 'frame->fp <= fp' with 'frame->fp == fp'.
>
>No, just drop the patch. It was already reverted upstream in
>e87a4a92fba3. Can the AUTOSEL robot check for upstream reverts?

It does! Once when it grabs the patch and once right before Greg sees a
pull request. There's a (rather large - ~2 week) time gap in between
when fixes/reverts sneak in.

Thanks for the review, I'll drop the patch.

--
Thanks,
Sasha