linux-kernel - Re: [PATCH] use STORE_LOCKED instead of STORE macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 Sep 2018 23:44:16 +0800
From:   Coly Li <colyli@...e.de>
To:     Dongbo Cao <cdbdyx@....com>
Cc:     kent.overstreet@...il.com, linux-bcache@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] use STORE_LOCKED instead of STORE macro


On 9/27/18 1:31 PM, Dongbo Cao wrote:
> merge sysfs_writeback_running attr and sysfs_writeback_percent attr together with other attrs of cached_dev.
>
> Signed-off-by: Dongbo Cao <cdbdyx@....com>

Could you please to explain more what you want to do, and why you make 
this change?

Thanks.


Coly Li

> ---
>   drivers/md/bcache/sysfs.c | 15 ++-------------
>   1 file changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
> index 26f035a0..14fc9104 100644
> --- a/drivers/md/bcache/sysfs.c
> +++ b/drivers/md/bcache/sysfs.c
> @@ -245,7 +245,7 @@ SHOW(__bch_cached_dev)
>   }
>   SHOW_LOCKED(bch_cached_dev)
>   
> -STORE(__cached_dev)
> +STORE(__bch_cached_dev)
>   {
>   	struct cached_dev *dc = container_of(kobj, struct cached_dev,
>   					     disk.kobj);
> @@ -373,17 +373,6 @@ STORE(__cached_dev)
>   	if (attr == &sysfs_stop)
>   		bcache_device_stop(&dc->disk);
>   
> -	return size;
> -}
> -
> -STORE(bch_cached_dev)
> -{
> -	struct cached_dev *dc = container_of(kobj, struct cached_dev,
> -					     disk.kobj);
> -
> -	mutex_lock(&bch_register_lock);
> -	size = __cached_dev_store(kobj, attr, buf, size);
> -
>   	if (attr == &sysfs_writeback_running)
>   		bch_writeback_queue(dc);
>   
> @@ -392,9 +381,9 @@ STORE(bch_cached_dev)
>   			schedule_delayed_work(&dc->writeback_rate_update,
>   				      dc->writeback_rate_update_seconds * HZ);
>   
> -	mutex_unlock(&bch_register_lock);
>   	return size;
>   }
> +STORE_LOCKED(bch_cached_dev)
>   
>   static struct attribute *bch_cached_dev_files[] = {
>   	&sysfs_attach,