linux-kernel - Re: [PATCH v3 3/3] i2c: i2c-qcom-geni: Simplify irq handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 04 Oct 2018 13:16:26 +0530
From:   alokc@...eaurora.org
To:     Doug Anderson <dianders@...omium.org>
Cc:     Stephen Boyd <swboyd@...omium.org>,
        Wolfram Sang <wsa@...-dreams.de>,
        LKML <linux-kernel@...r.kernel.org>, linux-i2c@...r.kernel.org,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Karthikeyan Ramasubramanian <kramasub@...eaurora.org>,
        Sagar Dharia <sdharia@...eaurora.org>,
        Girish Mahadevan <girishm@...eaurora.org>,
        linux-i2c-owner@...r.kernel.org
Subject: Re: [PATCH v3 3/3] i2c: i2c-qcom-geni: Simplify irq handler

On 2018-09-26 03:19, Doug Anderson wrote:
> Hi,
> 
> On Mon, Sep 24, 2018 at 4:52 PM Stephen Boyd <swboyd@...omium.org> 
> wrote:
>> 
>> We don't need to use goto here, we can just collapse the if statement
>> and goto chain into multiple branches and then combine some duplicate
>> completion calls into one big if statement. Let's do it to clean up 
>> code
>> some more.
>> 
>> Cc: Karthikeyan Ramasubramanian <kramasub@...eaurora.org>
>> Cc: Sagar Dharia <sdharia@...eaurora.org>
>> Cc: Girish Mahadevan <girishm@...eaurora.org>
>> Cc: Doug Anderson <dianders@...omium.org>
>> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
>> ---
>>  drivers/i2c/busses/i2c-qcom-geni.c | 70 
>> +++++++++++++-----------------
>>  1 file changed, 29 insertions(+), 41 deletions(-)
> 
> It doesn't gleam as powerfully the cleanups in patch 2/3 but this does
> have a few nice readability improvements.
> 
> Reviewed-by: Douglas Anderson <dianders@...omium.org>

agree.

Reviewed-by: Alok Chauhan <alokc@...eaurora.org>

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,a Linux Foundation Collaborative Project