linux-kernel - Re: [PATCH] rtc: m41t80: fix fall-through annotation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 4 Oct 2018 15:01:29 +0200
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: m41t80: fix fall-through annotation



On 10/4/18 2:53 PM, Alexandre Belloni wrote:
> Hi,
> 
> On 04/10/2018 14:35:28+0200, Gustavo A. R. Silva wrote:
>> Replace "Fall" with a proper "Fall through" annotation.
>>
>> This fix is part of the ongoing efforts to enabling
>> -Wimplicit-fallthrough
>>
> 
> Can we agree that this is absolutely not a fix? I don't wan't to have
> that needlessly backport on gazillion stable kernel.
> 

Well, as clearly the intention of the developer was to add a fall-through
comment, but it was incomplete, I considered this a fix. But, I see your
point and I agree. There is not need for this to be applied to stable trees.

I will change the subject.

Thanks
--
Gustavo