linux-kernel - Re: [PATCH -next] eeprom: at25: remove unneeded 'at25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 5 Oct 2018 09:43:20 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     gregkh <gregkh@...uxfoundation.org>,
        devang.panchal@...tnautics.com,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Rob Herring <robh@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] eeprom: at25: remove unneeded 'at25_remove'

On Fri, Oct 5, 2018 at 8:08 AM YueHaibing <yuehaibing@...wei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/misc/eeprom/at25.c: In function 'at25_remove':
> drivers/misc/eeprom/at25.c:384:20: warning:
>  variable 'at25' set but not used [-Wunused-but-set-variable]
>
> Since commit 96d08fb43e30 ("eeprom: at25: use devm_nvmem_register()"),
> at25_remove is do nothing, so can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

I had to double-check that removing the remove callback doesn't
result in a device that you cannot remove, but it is in fact supported, so

Acked-by: Arnd Bergmann <arnd@...db.de>