linux-kernel - Re: [PATCH] arm64: dts: k3-am65-wakeup: Fix wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 Oct 2018 14:10:16 -0500
From:   Nishanth Menon <nm@...com>
To:     Vignesh R <vigneshr@...com>
CC:     Tero Kristo <t-kristo@...com>, Rob Herring <robh+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: k3-am65-wakeup: Fix wakeup_uart reg address

On 05:01-20180927, Vignesh R wrote:
> cbass_wakeup interconnect which is the parent of wakeup_uart node
> defines address-cells=1 and size-cells=1, therefore fix up reg property
> of wakeup_uart node accordingly. Otherwise, this UART instance fails to
> probe if enabled.
> 
> Fixes: 4201af2544b3 ("arm64: dts: ti: am654: Add uart nodes")
> Signed-off-by: Vignesh R <vigneshr@...com>
> ---
> 
> Based on next-20180926
> 
>  arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> index ee56959f4af8..c617393ea767 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> @@ -44,7 +44,7 @@
>  
>  	wkup_uart0: serial@...00000 {
>  		compatible = "ti,am654-uart";
> -		reg = <0x00 0x42300000 0x00 0x100>;
> +		reg = <0x42300000 0x100>;
>  		reg-shift = <2>;
>  		reg-io-width = <4>;
>  		interrupts = <GIC_SPI 697 IRQ_TYPE_LEVEL_HIGH>;


Thanks. Tero: we should probably queue for rc fixes. wkup_uart is used
by System Firmware logs (if enabled), so kernel usage is limited to some
specific platforms. This is a valid fix and my miss..

Acked-by: Nishanth Menon <nm@...com>

-- 
Regards,
Nishanth Menon