[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 10 Oct 2018 08:30:11 -0700
From: Tejun Heo <tj@...nel.org>
To: Alexander Duyck <alexander.h.duyck@...ux.intel.com>
Cc: gregkh@...uxfoundation.org, akpm@...ux-foundation.org,
linux-kernel@...r.kernel.org, len.brown@...el.com,
rafael@...nel.org, linux-pm@...r.kernel.org,
jiangshanlai@...il.com, pavel@....cz, zwisler@...nel.org
Subject: Re: [workqueue/driver-core PATCH 1/5] workqueue: Provide
queue_work_near to queue work near a given NUMA node
Hello,
> +static int workqueue_select_cpu_near(int node)
> +{
...
> + /* Use "random" otherwise know as "first" online CPU of node */
> + cpu = cpumask_any_and(cpumask_of_node(node), cpu_online_mask);
Maybe we wanna round-robin within the node?
> +bool queue_work_near(int node, struct workqueue_struct *wq,
> + struct work_struct *work)
Can we name it queue_work_node() to stay consistent with numa-aware
memory interface?
Thanks.
--
tejun
Powered by blists - more mailing lists