[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Wed, 10 Oct 2018 19:26:56 +0200
From: Lubomir Rintel <lkundrak@...sk>
To: Robert Jarzmik <robert.jarzmik@...e.fr>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-pci@...r.kernel.org, linux-spi@...r.kernel.org,
devicetree@...r.kernel.org, Mark Brown <broonie@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Eric Miao <eric.y.miao@...il.com>,
Haojian Zhuang <haojian.zhuang@...il.com>,
Daniel Mack <daniel@...que.org>,
Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH 3/5] spi: pxa2xx: use an enum for type
On Fri, 2018-09-21 at 22:34 +0200, Robert Jarzmik wrote:
> Lubomir Rintel <lkundrak@...sk> writes:
>
> > That seems to be the correct type.
> Okay, but what happens here when adev_id->driver_data is a value out
> of enum
> range ? Does the following assignment make sense ?
> > + type = (enum pxa_ssp_type)adev_id->driver_data;
>
> As a side note, could you join for the next throw to the review :
> - Jarkko Nikula <jarkko.nikula@...ux.intel.com>
> - Mika Westerberg <mika.westerberg@...ux.intel.com>
Argh, of course I forgot. My apologies.
Jarkko & Mika, I'm wondering if you could take a look at the [1] thread
and tell me what you think. (I can forward it to you via e-mail too, if
you're not subscribed to lists it has been Cc'd to, if that would be
more convenient).
[1] [PATCH 0/11] spi: pxa2xx: add DT and slave mode support"
https://lore.kernel.org/lkml/20181010170936.316862-1-lkundrak@v3.sk/T/#t
Thanks
Lubo
>
> Even if they are Intel, I think they have worked a lot on this driver
> for Intel
> platforms.
>
> Cheers.
>
Powered by blists - more mailing lists