| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 11 Oct 2018 03:30:05 +0800
From: kernel test robot <lkp@...el.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: LKP <lkp@...org>, linux-kernel@...r.kernel.org,
Ingo Molnar <mingo@...nel.org>
Subject: 1be3f247c2 ("x86/mm: Avoid VLA in pgd_alloc()"): WARNING: CPU: 0 PID: 1 at arch/x86/mm/dump_pagetables.c:283 note_page
Greetings,
0day kernel testing robot got the below dmesg and the first bad commit is
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
commit 1be3f247c2882a82279cbcf43717581ea943b692
Author: Arnd Bergmann <arnd@...db.de>
AuthorDate: Fri Oct 5 18:13:16 2018 +0200
Commit: Ingo Molnar <mingo@...nel.org>
CommitDate: Fri Oct 5 18:16:55 2018 +0200
x86/mm: Avoid VLA in pgd_alloc()
Turning on -Wvla found a new VLA usage:
arch/x86/mm/pgtable.c: In function 'pgd_alloc':
include/linux/build_bug.h:29:45: error: ISO C90 forbids variable length array 'u_pmds' [-Werror=vla]
arch/x86/mm/pgtable.c:190:34: note: in expansion of macro 'static_cpu_has'
#define PREALLOCATED_USER_PMDS (static_cpu_has(X86_FEATURE_PTI) ? \
^~~~~~~~~~~~~~
arch/x86/mm/pgtable.c:431:16: note: in expansion of macro 'PREALLOCATED_USER_PMDS'
pmd_t *u_pmds[PREALLOCATED_USER_PMDS];
^~~~~~~~~~~~~~~~~~~~~~
Use the actual size of the array that is used for X86_FEATURE_PTI
instead of the variable size.
Signed-off-by: Arnd Bergmann <arnd@...db.de>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Andy Lutomirski <luto@...nel.org>
Cc: Borislav Petkov <bp@...en8.de>
Cc: Dave Hansen <dave.hansen@...ux.intel.com>
Cc: Joerg Roedel <jroedel@...e.de>
Cc: Kees Cook <keescook@...omium.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Toshi Kani <toshi.kani@....com>
Fixes: 68664695ae57 ("Makefile: Globally enable VLA warning")
Fixes: f59dbe9ca670 ("x86/pgtable/pae: Use separate kernel PMDs for user page-table")
Link: http://lkml.kernel.org/r/20181005161333.765973-1-arnd@arndb.de
Signed-off-by: Ingo Molnar <mingo@...nel.org>
02e425668f x86/vdso: Fix vDSO syscall fallback asm constraint regression
1be3f247c2 x86/mm: Avoid VLA in pgd_alloc()
7f3049305d Add linux-next specific files for 20181010
+---------------------------------------------------------------------------------+------------+------------+---------------+
| | 02e425668f | 1be3f247c2 | next-20181010 |
+---------------------------------------------------------------------------------+------------+------------+---------------+
| boot_successes | 2 | 0 | 0 |
| boot_failures | 37 | 13 | 13 |
| WARNING:at_arch/x86/mm/dump_pagetables.c:#note_page | 37 | 11 | 13 |
| EIP:note_page | 37 | 11 | 13 |
| Kernel_panic-not_syncing:stack-protector:Kernel_stack_is_corrupted_in:pgd_alloc | 0 | 13 | 13 |
+---------------------------------------------------------------------------------+------------+------------+---------------+
[ 4.542866] Write protecting the kernel text: 8064k
[ 4.543445] Write protecting the kernel read-only data: 2512k
[ 4.544085] NX-protecting the kernel data: 6272k
[ 4.544782] ------------[ cut here ]------------
[ 4.545294] x86/mm: Found insecure W+X mapping at address (ptrval)/0x400a0000
[ 4.546083] WARNING: CPU: 0 PID: 1 at arch/x86/mm/dump_pagetables.c:283 note_page+0x775/0x9a0
[ 4.547210] Modules linked in:
[ 4.547554] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G T 4.19.0-rc6-00008-g1be3f24 #3
[ 4.548537] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1 04/01/2014
[ 4.549509] EIP: note_page+0x775/0x9a0
[ 4.549960] Code: c6 05 0d 02 10 50 01 c7 04 24 01 00 00 00 e8 32 d4 0e 00 8b 43 14 c7 04 24 38 61 fa 4f 89 44 24 08 89 44 24 04 e8 bb bf 00 00 <0f> 0b 31 c9 ba 01 00 00 00 b8 48 10 12 50 c7 04 24 01 00 00 00 e8
[ 4.551980] EAX: 00000041 EBX: 55d19f28 ECX: 00000000 EDX: 00000000
[ 4.552658] ESI: 00000002 EDI: 00000000 EBP: 55d19ed0 ESP: 55d19e90
[ 4.553349] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068 EFLAGS: 00210202
[ 4.554095] CR0: 80050033 CR2: 00000000 CR3: 1029a000 CR4: 000006f0
[ 4.554787] Call Trace:
[ 4.555069] ? ptdump_walk_pgd_level_core+0x2ca/0x430
[ 4.555621] ? ptdump_walk_pgd_level_checkwx+0x20/0x30
[ 4.556195] ? mark_rodata_ro+0x135/0x160
[ 4.556638] ? rest_init+0xc0/0xc0
[ 4.557026] ? kernel_init+0x36/0x110
[ 4.557431] ? schedule_tail_wrapper+0x9/0xc
[ 4.557909] ? ret_from_fork+0x19/0x24
[ 4.558327] ---[ end trace 60fc883517612381 ]---
[ 4.559168] x86/mm: Checked W+X mappings: FAILED, 96 W+X pages found.
# HH:MM RESULT GOOD BAD GOOD_BUT_DIRTY DIRTY_NOT_BAD
git bisect start 7f3049305d22fc543f836d00aeea41ecef911199 0238df646e6224016a45505d2c111a24669ebe21 --
git bisect good 2cca37b51d8e170e155d7f48e2ed70eb173d6683 # 22:26 G 11 0 11 11 Merge remote-tracking branch 'pm/linux-next'
git bisect good e98a5fe7876fd5973cef61a456871f309b33e16d # 22:39 G 11 0 11 11 Merge remote-tracking branch 'mailbox/mailbox-for-next'
git bisect bad 8667f75a95698773efa55d7fbdef4bad664f7060 # 22:54 B 0 11 26 0 Merge remote-tracking branch 'staging/staging-next'
git bisect bad 1aa53b331a38c3dd9043cc83dfea942ecb4d420f # 23:09 B 0 8 23 0 Merge remote-tracking branch 'xen-tip/linux-next'
git bisect bad 141a3469aafcf6b6e63a307ad8766a9a2ed63416 # 23:27 B 0 11 26 0 Merge remote-tracking branch 'rcu/rcu/next'
git bisect bad 6a2e03f7dd9fec432789e77c34743c8773155461 # 23:40 B 0 3 18 0 Merge remote-tracking branch 'tip/auto-latest'
git bisect good 6818e8c338148c99696d3958f5661075c23a39bc # 00:02 G 11 0 11 11 Merge remote-tracking branch 'spi/for-next'
git bisect good fac07d2ba7b2764e3002ff9bc7861742a84a2ef6 # 00:17 G 11 0 11 13 Merge branch 'perf/core'
git bisect good 245e5707dd7df01428459d97a9121f14a57dac6b # 00:29 G 11 0 11 11 Merge branch 'x86/build'
git bisect bad d74865bd3996c7a6f3e8ce6e626c1fe474e39494 # 00:45 B 0 11 28 2 Merge branch 'x86/mm'
git bisect bad ff5a98047da9c79f295e976cb8f227802a0aba00 # 01:00 B 0 11 27 1 Merge branch 'x86/early-printk'
git bisect good 4044240365e85ef7ae43a6dc454669b57853124c # 01:17 G 11 0 11 11 x86/xen: Add Hygon Dhyana support to Xen
git bisect bad edbdd2c8bd30da45629e6466714c86eec915364a # 01:35 B 0 11 26 0 x86/intel_rdt: CBM overlap should also check for overlap with CDP peer
git bisect good 2cc81c6992248ea37d0241bc325977bab310bc3b # 01:47 G 11 0 11 11 x86/intel_rdt: Show missing resctrl mount options
git bisect bad e8bd1803aec89dfce5758d88022963fe3248bc4c # 02:00 B 0 11 26 0 x86/intel_rdt: Fix out-of-bounds memory access in CBM tests
git bisect bad 1be3f247c2882a82279cbcf43717581ea943b692 # 02:09 B 0 11 26 0 x86/mm: Avoid VLA in pgd_alloc()
# first bad commit: [1be3f247c2882a82279cbcf43717581ea943b692] x86/mm: Avoid VLA in pgd_alloc()
git bisect good 02e425668f5c9deb42787d10001a3b605993ad15 # 02:33 G 33 0 33 33 x86/vdso: Fix vDSO syscall fallback asm constraint regression
# extra tests with debug options
git bisect bad 1be3f247c2882a82279cbcf43717581ea943b692 # 02:44 B 0 4 19 0 x86/mm: Avoid VLA in pgd_alloc()
# extra tests on HEAD of linux-next/master
git bisect bad 7f3049305d22fc543f836d00aeea41ecef911199 # 02:49 B 0 13 31 0 Add linux-next specific files for 20181010
# extra tests on tree/branch linux-next/master
git bisect bad 7f3049305d22fc543f836d00aeea41ecef911199 # 02:50 B 0 13 31 0 Add linux-next specific files for 20181010
# extra tests with first bad commit reverted
git bisect good 8fbba563cf92c53cfaa19dfde35227f3be3a079e # 03:28 G 11 0 11 11 Revert "x86/mm: Avoid VLA in pgd_alloc()"
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/lkp Intel Corporation
Download attachment "dmesg-quantal-ivb41-64:20181011020847:i386-randconfig-b0-10101847:4.19.0-rc6-00008-g1be3f24:3.gz" of type "application/gzip" (13965 bytes)
Download attachment "dmesg-quantal-ivb41-101:20181011023248:i386-randconfig-b0-10101847:4.19.0-rc6-00007-g02e4256:2.gz" of type "application/gzip" (19770 bytes)
View attachment "reproduce-quantal-ivb41-64:20181011020847:i386-randconfig-b0-10101847:4.19.0-rc6-00008-g1be3f24:3" of type "text/plain" (907 bytes)
View attachment "config-4.19.0-rc6-00008-g1be3f24" of type "text/plain" (115214 bytes)
Powered by blists - more mailing lists