linux-kernel - Re: [PATCH v4 5/6] parisc: wire up rseq system call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 Oct 2018 22:23:29 +0200
From:   Helge Deller <deller@....de>
To:     Arnd Bergmann <arnd@...db.de>, Firoz Khan <firoz.khan@...aro.org>
Cc:     Parisc List <linux-parisc@...r.kernel.org>,
        "James E.J. Bottomley" <jejb@...isc-linux.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        gregkh <gregkh@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        Marcin Juszkiewicz <marcin.juszkiewicz@...aro.org>
Subject: Re: [PATCH v4 5/6] parisc: wire up rseq system call

On 12.10.2018 13:52, Arnd Bergmann wrote:
> On Fri, Oct 12, 2018 at 12:16 PM Firoz Khan <firoz.khan@...aro.org> wrote:
>>
>> Hi Arnd,
>>
>> On Fri, 12 Oct 2018 at 15:26, Arnd Bergmann <arnd@...db.de> wrote:
>>>
>>> On Fri, Oct 12, 2018 at 11:45 AM Firoz Khan <firoz.khan@...aro.org> wrote:
>>>>
>>>> Wire up rseq system call requires an architecture specific
>>>> implementation as it not present now.
>>>>
>>>> Signed-off-by: Firoz Khan <firoz.khan@...aro.org>
>>>
>>> Didn't we conclude that this should be skipped?
>>
>> Helge told "I prefer to keep the warning for rseq for now.
>> It reminds me that we still may want the rseq syscall.
>> If the warning is a problem, you may simply add the __IGNORE_rseq define."
>>
>> I chose this option; I feel it looks clean
>> "# rseq requires an architecture specific implementation" in syscall.tbl
>> hopefully remind him to add rseq syscall implementation in this architecture.
> 
> But he said he wants the warning instead.

Correct.
Firoz, please simply drop this patch completely.
That way one will see generated warnings about the missing rseq (which is what
we want).

Thanks,
Helge