linux-kernel - Re: [PATCH] tty: serial: qcom_geni_serial: Rectify UART suspend mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 Oct 2018 13:24:52 -0700
From:   Doug Anderson <dianders@...gle.com>
To:     msavaliy@...eaurora.org
Cc:     alokc@...eaurora.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tty: serial: qcom_geni_serial: Rectify UART suspend mechanism

Hi,

On Tue, Oct 16, 2018 at 7:11 AM Mukesh, Savaliya
<msavaliy@...eaurora.org> wrote:
>
> From: Mukesh Kumar Savaliya <msavaliy@...eaurora.org>
>
> UART driver checks for the PM state and denies suspend if state is ACTIVE.
> This makes UART to deny suspend when client keeps port open which is not
> correct. Instead follow framework and obey suspend-resume callbacks.
>
> Signed-off-by: Mukesh Kumar Savaliya <msavaliy@...eaurora.org>
> ---
>  drivers/tty/serial/qcom_geni_serial.c | 36 ++++++-----------------------------
>  1 file changed, 6 insertions(+), 30 deletions(-)

Looks peachy.  Getting rid of all that unnecessary code and moving
away from the "no_irq" suspend op makes lots of sense to me.

Reviewed-by: Douglas Anderson <dianders@...omium.org>