linux-kernel - [PATCH] c6x: remove redundant 'default n' from Kconfig-s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 16 Oct 2018 15:31:06 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Mark Salter <msalter@...hat.com>,
        Aurelien Jacquiot <jacquiot.aurelien@...il.com>
Cc:     linux-c6x-dev@...ux-c6x.org, linux-kernel@...r.kernel.org
Subject: [PATCH] c6x: remove redundant 'default n' from Kconfig-s

'default n' is the default value for any bool or tristate Kconfig
setting so there is no need to write it explicitly.

Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
is not set' for visible symbols") the Kconfig behavior is the same
regardless of 'default n' being present or not:

    ...
    One side effect of (and the main motivation for) this change is making
    the following two definitions behave exactly the same:
    
        config FOO
                bool
    
        config FOO
                bool
                default n
    
    With this change, neither of these will generate a
    '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
    That might make it clearer to people that a bare 'default n' is
    redundant.
    ...

Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
---
 arch/c6x/Kconfig           |    2 --
 arch/c6x/platforms/Kconfig |    5 -----
 2 files changed, 7 deletions(-)

Index: b/arch/c6x/Kconfig
===================================================================
--- a/arch/c6x/Kconfig	2018-10-09 15:58:36.295122871 +0200
+++ b/arch/c6x/Kconfig	2018-10-16 15:28:50.623630380 +0200
@@ -70,14 +70,12 @@ config CMDLINE
 config CMDLINE_FORCE
 	bool "Force default kernel command string"
 	depends on CMDLINE_BOOL
-	default n
 	help
 	  Set this to have arguments from the default kernel command string
 	  override those passed by the boot loader.
 
 config CPU_BIG_ENDIAN
 	bool "Build big-endian kernel"
-	default n
 	help
 	  Say Y if you plan on running a kernel in big-endian mode.
 	  Note that your board must be properly built and your board
Index: b/arch/c6x/platforms/Kconfig
===================================================================
--- a/arch/c6x/platforms/Kconfig	2018-09-03 18:11:11.249792456 +0200
+++ b/arch/c6x/platforms/Kconfig	2018-10-16 15:29:04.891630739 +0200
@@ -2,20 +2,15 @@
 
 config SOC_TMS320C6455
 	bool "TMS320C6455"
-	default n
 
 config SOC_TMS320C6457
 	bool "TMS320C6457"
-	default n
 
 config SOC_TMS320C6472
 	bool "TMS320C6472"
-	default n
 
 config SOC_TMS320C6474
 	bool "TMS320C6474"
-	default n
 
 config SOC_TMS320C6678
 	bool "TMS320C6678"
-	default n