linux-kernel - Re: [PATCH -next] scsi: hisi_sas: Remove set but not used variable 'dq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Oct 2018 09:17:38 +0100
From:   John Garry <john.garry@...wei.com>
To:     YueHaibing <yuehaibing@...wei.com>, <jejb@...ux.vnet.ibm.com>,
        <martin.petersen@...cle.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH -next] scsi: hisi_sas: Remove set but not used variable
 'dq_list'

On 26/10/2018 08:07, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/hisi_sas/hisi_sas_v1_hw.c: In function 'start_delivery_v1_hw':
> drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:907:20: warning:
>  variable 'dq_list' set but not used [-Wunused-but-set-variable]
>
> drivers/scsi/hisi_sas/hisi_sas_v2_hw.c: In function 'start_delivery_v2_hw':
> drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:1671:20: warning:
>  variable 'dq_list' set but not used [-Wunused-but-set-variable]
>
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: In function 'start_delivery_v3_hw':
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:889:20: warning:
>  variable 'dq_list' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in commit
> fa222db0b036 ("scsi: hisi_sas: Don't lock DQ for complete task sending")
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Acked-by: John Garry <john.garry@...wei.com>