linux-kernel - Re: [PATCH] tpm: tpm_ibmvtpm: fix kdoc warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 30 Oct 2018 13:23:01 +0200 (EET)
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Tomas Winkler <tomas.winkler@...el.com>
cc:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Nayna Jain <nayna@...ux.vnet.ibm.com>,
        Alexander Usyskin <alexander.usyskin@...el.com>,
        Tadeusz Struk <tadeusz.struk@...el.com>,
        linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tpm: tpm_ibmvtpm: fix kdoc warnings

On Fri, 26 Oct 2018, Tomas Winkler wrote:
> Remove redundant lines in the kdoc:
>
> Fixes kdoc warnings:
>
> drivers/char/tpm/tpm_ibmvtpm.c:42: warning: Cannot understand  *
> on line 42 - I thought it was a doc line
> drivers/char/tpm/tpm_ibmvtpm.c:57: warning: Cannot understand  *
> on line 57 - I thought it was a doc line
>
> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> ---
> drivers/char/tpm/tpm_ibmvtpm.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index 25f6e2665385..07b5a487d0c8 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -39,8 +39,7 @@ static const struct vio_device_id tpm_ibmvtpm_device_table[] = {
> MODULE_DEVICE_TABLE(vio, tpm_ibmvtpm_device_table);
>
> /**
> - *
> - * ibmvtpm_send_crq_word - Send a CRQ request
> + * ibmvtpm_send_crq_word() - Send a CRQ request
>  * @vdev:	vio device struct
>  * @w1:		pre-constructed first word of tpm crq (second word is reserved)
>  *
> @@ -54,8 +53,7 @@ static int ibmvtpm_send_crq_word(struct vio_dev *vdev, u64 w1)
> }
>
> /**
> - *
> - * ibmvtpm_send_crq - Send a CRQ request
> + * ibmvtpm_send_crq() - Send a CRQ request
>  *
>  * @vdev:	vio device struct
>  * @valid:	Valid field
> -- 
> 2.14.5
>
>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>

/Jarkko