Date:   Tue, 30 Oct 2018 12:31:03 +0000
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Daniel Thompson <daniel.thompson@...aro.org>
Cc:     Douglas Anderson <dianders@...omium.org>,
        Jason Wessel <jason.wessel@...driver.com>, tglx@...utronix.de,
        mingo@...nel.org, gregkh@...uxfoundation.org,
        linux-arm-msm@...r.kernel.org,
        kgdb-bugreport@...ts.sourceforge.net, nm@...com,
        linux-mips@...ux-mips.org, dalias@...c.org,
        catalin.marinas@....com, vigneshr@...com,
        linux-aspeed@...ts.ozlabs.org, linux-sh@...r.kernel.org,
        peterz@...radead.org, will.deacon@....com, mhocko@...e.com,
        paulus@...ba.org, hpa@...or.com, sparclinux@...r.kernel.org,
        marex@...x.de, sfr@...b.auug.org.au, ysato@...rs.sourceforge.jp,
        linux-hexagon@...r.kernel.org, x86@...nel.org,
        pombredanne@...b.com, tony@...mide.com, mingo@...hat.com,
        joel@....id.au, linux-serial@...r.kernel.org,
        rolf.evers.fischer@...iv.com, jhogan@...nel.org,
        asierra@...-inc.com, linux-snps-arc@...ts.infradead.org,
        dan.carpenter@...cle.com, ying.huang@...el.com, riel@...riel.com,
        frederic@...nel.org, jslaby@...e.com, paul.burton@...s.com,
        rppt@...ux.vnet.ibm.com, bp@...en8.de, luto@...nel.org,
        andriy.shevchenko@...ux.intel.com,
        linux-arm-kernel@...ts.infradead.org, christophe.leroy@....fr,
        andrew@...id.au, linux-kernel@...r.kernel.org, ralf@...ux-mips.org,
        rkuo@...eaurora.org, Jisheng.Zhang@...aptics.com,
        vgupta@...opsys.com, benh@...nel.crashing.org, jk@...abs.org,
        mpe@...erman.id.au, akpm@...ux-foundation.org,
        linuxppc-dev@...ts.ozlabs.org, davem@...emloft.net,
        kstewart@...uxfoundation.org
Subject: Re: [PATCH 0/7] serial: Finish kgdb on qcom_geni; fix many lockdep
 splats w/ kgdb

On Tue, Oct 30, 2018 at 11:56:28AM +0000, Daniel Thompson wrote:
> On Mon, Oct 29, 2018 at 11:07:00AM -0700, Douglas Anderson wrote:
> > Looking back, this is pretty much two series squashed that could be
> > treated indepdently.  The first is a serial series and the second is a
> > kgdb series.
> 
> Indeed.
> 
> I couldn't work out the link between the first 5 patches and the last 2
> until I read this...
> 
> Is anything in the 01->05 patch set even related to kgdb? From the stack
> traces it looks to me like the lock dep warning would trigger for any
> sysrq. I think separating into two threads for v2 would be sensible.

I'm concerned about calling smp_call_function() from IRQ context with
IRQs disabled - that will block the ability of the _calling_ CPU to
process IPIs from other CPUs in the system.  If we have other CPUs
waiting on their IPIs to complete on _this_ CPU, we could end up
deadlocking while trying to grab the CSD lock.

This is the intention of warnings in smp_call_function*() - to catch
cases where deadlocks _can_ occur, but do not reliably show up.

The exceptions to the warning (disregarding oops_in_progress) are
chosen to allow IRQs-disabled calls when we're sure that the rest of
the system isn't going to be sending the calling CPU an IPI (eg,
because the CPU isn't marked online, and we only send IPIs to online
CPUs, or if we're still early in the kernel boot and hence have no
other CPUs running.)  The exception is oops_in_progress, which can
occur at any time - even with the current CPU already holding some
CSD locks (eg, oops while trying to send an IPI.)

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

Powered by blists - more mailing lists