linux-kernel - Re: [REGRESSION] OCTEON MMC driver failure with v4.19

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 6 Nov 2018 23:51:57 +0200
From:   Aaro Koskinen <aaro.koskinen@....fi>
To:     Christoph Hellwig <hch@....de>
Cc:     Robin Murphy <robin.murphy@....com>, Rob Herring <robh@...nel.org>,
        Paul Burton <paul.burton@...s.com>, linux-mips@...ux-mips.org,
        linux-kernel@...r.kernel.org
Subject: Re: [REGRESSION] OCTEON MMC driver failure with v4.19

Hi,

On Tue, Nov 06, 2018 at 11:05:11AM +0200, Aaro Koskinen wrote:
> On Tue, Nov 06, 2018 at 07:27:24AM +0100, Christoph Hellwig wrote:
> > On Tue, Nov 06, 2018 at 12:06:32AM +0200, Aaro Koskinen wrote:
> > > With the below change, the MMC card probe seems to with v4.19. But it
> > > feels a bit hackish, don't you think... Is there some obvious simple
> > > fix that I'm missing? Any comments?
> > 
> > Please just use dma_coerce_mask_and_coherent in the platform drivers
> > instead.
> 
> Tried, but that doesn't help with v4.19:
> 
> [    1.290698] octeon_mmc 1180000002000.mmc: dma_coerce_mask_and_coherent(): -5
> [    1.297825] octeon_mmc: probe of 1180000002000.mmc failed with error -5
> 
> A.

Just for the archives, the fix is: https://patchwork.kernel.org/patch/10670177/

A.