linux-kernel - Re: [PATCH net-next] net: hns3: Remove set but not used variable 'reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 07 Nov 2018 11:46:59 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        shiju.jose@...wei.com, colin.king@...onical.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: hns3: Remove set but not used variable
 'reset_level'

From: YueHaibing <yuehaibing@...wei.com>
Date: Wed, 7 Nov 2018 02:33:53 +0000

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c: In function 'hclge_log_and_clear_ppp_error':
> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c:821:24: warning:
>  variable 'reset_level' set but not used [-Wunused-but-set-variable]
>   enum hnae3_reset_type reset_level = HNAE3_NONE_RESET;
> 
> It never used since introduction in commit
> 01865a50d78f ("net: hns3: Add enable and process hw errors of TM scheduler")
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied, thanks.