linux-kernel - Re: [PATCH 09/11] mfd: tps65910: Make it explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Nov 2018 08:56:13 +0000
From:   Graeme Gregory <gg@...mlogic.co.uk>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>,
        Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org, Tony Lindgren <tony@...mide.com>,
        Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH 09/11] mfd: tps65910: Make it explicitly non-modular



On Thu, 22 Nov 2018, at 4:32 AM, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> drivers/mfd/Kconfig:config MFD_TPS65910
> drivers/mfd/Kconfig-    bool "TI TPS65910 Power Management chip"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> Since module_init was not in use by this code, the init ordering
> remains unchanged with this commit.
> 
> We don't replace module.h with init.h since the file already has that.
> We do delete an unused moduleparam.h include though.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
> 
This is all fine with me.

Acked-by: Graeme Gregory <gg@...mlogic.co.uk>

Thanks

> Cc: Tony Lindgren <tony@...mide.com>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Graeme Gregory <gg@...mlogic.co.uk>
> Cc: Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>
> Cc: linux-omap@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  drivers/mfd/tps65910.c | 18 +-----------------
>  1 file changed, 1 insertion(+), 17 deletions(-)
> 
> diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
> index bf16cbe6fd88..aa3d472a10ff 100644
> --- a/drivers/mfd/tps65910.c
> +++ b/drivers/mfd/tps65910.c
> @@ -1,5 +1,5 @@
>  /*
> - * tps65910.c  --  TI TPS6591x
> + * tps65910.c  --  TI TPS6591x chip family multi-function driver
>   *
>   * Copyright 2010 Texas Instruments Inc.
>   *
> @@ -13,8 +13,6 @@
>   *
>   */
>  
> -#include <linux/module.h>
> -#include <linux/moduleparam.h>
>  #include <linux/init.h>
>  #include <linux/err.h>
>  #include <linux/slab.h>
> @@ -374,7 +372,6 @@ static const struct of_device_id tps65910_of_match[] = {
>  	{ .compatible = "ti,tps65911", .data = (void *)TPS65911},
>  	{ },
>  };
> -MODULE_DEVICE_TABLE(of, tps65910_of_match);
>  
>  static struct tps65910_board *tps65910_parse_dt(struct i2c_client *client,
>  						unsigned long *chip_id)
> @@ -527,8 +524,6 @@ static const struct i2c_device_id tps65910_i2c_id[] = {
>         { "tps65911", TPS65911 },
>         { }
>  };
> -MODULE_DEVICE_TABLE(i2c, tps65910_i2c_id);
> -
>  
>  static struct i2c_driver tps65910_i2c_driver = {
>  	.driver = {
> @@ -545,14 +540,3 @@ static int __init tps65910_i2c_init(void)
>  }
>  /* init early so consumer devices can complete system boot */
>  subsys_initcall(tps65910_i2c_init);
> -
> -static void __exit tps65910_i2c_exit(void)
> -{
> -	i2c_del_driver(&tps65910_i2c_driver);
> -}
> -module_exit(tps65910_i2c_exit);
> -
> -MODULE_AUTHOR("Graeme Gregory <gg@...mlogic.co.uk>");
> -MODULE_AUTHOR("Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>");
> -MODULE_DESCRIPTION("TPS6591x chip family multi-function driver");
> -MODULE_LICENSE("GPL");
> -- 
> 2.7.4
>