linux-kernel - Re: [PATCH v3 4/4] ARM: dts: Add stmpe-adc driver to relevant devicetrees

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 24 Nov 2018 14:20:58 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Philippe Schenker <dev@...henker.ch>, jic23@...nel.org,
        marcel.ziswiler@...adex.com, stefan@...er.ch
Cc:     Philippe Schenker <philippe.schenker@...adex.com>,
        Fabio Estevam <fabio.estevam@....com>,
        devicetree@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Mark Rutland <mark.rutland@....com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        NXP Linux Team <linux-imx@....com>
Subject: Re: [PATCH v3 4/4] ARM: dts: Add stmpe-adc driver to relevant
 devicetrees

On 23.11.2018 17:24, Philippe Schenker wrote:
> From: Philippe Schenker <philippe.schenker@...adex.com>
> 
> Activate the stmpe-adc driver as found on Apalis/Colibri iMX6/T30 modules
> 
> Signed-off-by: Philippe Schenker <philippe.schenker@...adex.com>

Hello Philippe,

Just a very minor comment.. device trees are not for drivers, but for HW description. It will be better to s/driver/DT node/ in both commit name and description.