linux-kernel - Re: [PATCH 1/2] kconfig: fix reverse dependency with tristate if-conditional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Nov 2018 16:15:59 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     kbuild-all@...org, linux-kbuild@...r.kernel.org,
        Ulf Magnusson <ulfalizer@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Taehee Yoo <ap420073@...il.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] kconfig: fix reverse dependency with tristate
 if-conditional

Hi Masahiro,

I love your patch! Yet something to improve:

[auto build test ERROR on masahiroy/kconfig]
[also build test ERROR on v4.20-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Masahiro-Yamada/kconfig-fix-reverse-dependency-with-tristate-if-conditional/20181126-152716
base:   https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git kconfig
config: i386-randconfig-s1-201847 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/input//mouse/synaptics.c: In function 'synaptics_create_intertouch':
>> drivers/input//mouse/synaptics.c:1754:9: error: implicit declaration of function 'psmouse_smbus_init' [-Werror=implicit-function-declaration]
     return psmouse_smbus_init(psmouse, &intertouch_board,
            ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/psmouse_smbus_init +1754 drivers/input//mouse/synaptics.c

e839ffab Benjamin Tissoires 2017-03-02  1728  
e839ffab Benjamin Tissoires 2017-03-02  1729  static int synaptics_create_intertouch(struct psmouse *psmouse,
e839ffab Benjamin Tissoires 2017-03-02  1730  				       struct synaptics_device_info *info,
e839ffab Benjamin Tissoires 2017-03-02  1731  				       bool leave_breadcrumbs)
e839ffab Benjamin Tissoires 2017-03-02  1732  {
e839ffab Benjamin Tissoires 2017-03-02  1733  	bool topbuttonpad =
e839ffab Benjamin Tissoires 2017-03-02  1734  		psmouse_matches_pnp_id(psmouse, topbuttonpad_pnp_ids) &&
e839ffab Benjamin Tissoires 2017-03-02  1735  		!SYN_CAP_EXT_BUTTONS_STICK(info->ext_cap_10);
e839ffab Benjamin Tissoires 2017-03-02  1736  	const struct rmi_device_platform_data pdata = {
e839ffab Benjamin Tissoires 2017-03-02  1737  		.sensor_pdata = {
e839ffab Benjamin Tissoires 2017-03-02  1738  			.sensor_type = rmi_sensor_touchpad,
e839ffab Benjamin Tissoires 2017-03-02  1739  			.axis_align.flip_y = true,
2b30297d Andrew Duggan      2017-10-09  1740  			.kernel_tracking = false,
e839ffab Benjamin Tissoires 2017-03-02  1741  			.topbuttonpad = topbuttonpad,
e839ffab Benjamin Tissoires 2017-03-02  1742  		},
e839ffab Benjamin Tissoires 2017-03-02  1743  		.f30_data = {
e839ffab Benjamin Tissoires 2017-03-02  1744  			.buttonpad = SYN_CAP_CLICKPAD(info->ext_cap_0c),
e839ffab Benjamin Tissoires 2017-03-02  1745  			.trackstick_buttons =
e839ffab Benjamin Tissoires 2017-03-02  1746  				!!SYN_CAP_EXT_BUTTONS_STICK(info->ext_cap_10),
e839ffab Benjamin Tissoires 2017-03-02  1747  		},
e839ffab Benjamin Tissoires 2017-03-02  1748  	};
e839ffab Benjamin Tissoires 2017-03-02  1749  	const struct i2c_board_info intertouch_board = {
e839ffab Benjamin Tissoires 2017-03-02  1750  		I2C_BOARD_INFO("rmi4_smbus", 0x2c),
e839ffab Benjamin Tissoires 2017-03-02  1751  		.flags = I2C_CLIENT_HOST_NOTIFY,
e839ffab Benjamin Tissoires 2017-03-02  1752  	};
e839ffab Benjamin Tissoires 2017-03-02  1753  
e839ffab Benjamin Tissoires 2017-03-02 @1754  	return psmouse_smbus_init(psmouse, &intertouch_board,
bf232e46 Benjamin Tissoires 2018-05-22  1755  				  &pdata, sizeof(pdata), true,
e839ffab Benjamin Tissoires 2017-03-02  1756  				  leave_breadcrumbs);
e839ffab Benjamin Tissoires 2017-03-02  1757  }
e839ffab Benjamin Tissoires 2017-03-02  1758  

:::::: The code at line 1754 was first introduced by commit
:::::: e839ffab028981ac77f650faf8c84f16e1719738 Input: synaptics - add support for Intertouch devices

:::::: TO: Benjamin Tissoires <benjamin.tissoires@...hat.com>
:::::: CC: Dmitry Torokhov <dmitry.torokhov@...il.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28649 bytes)