linux-kernel - Re: [PATCH net-next] qlcnic: remove set but not used variables 'cur_rings, max_hw_rings, tx_desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Nov 2018 11:10:20 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     Shahed.Shaikh@...ium.com, manish.chopra@...ium.com,
        Dept-GELinuxNICDev@...ium.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] qlcnic: remove set but not used variables
 'cur_rings, max_hw_rings, tx_desc_info'

From: YueHaibing <yuehaibing@...wei.com>
Date: Wed, 28 Nov 2018 20:29:39 +0800

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:4011:5:
>  warning: variable 'max_hw_rings' set but not used [-Wunused-but-set-variable]
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:4013:6:
>  warning: variable 'cur_rings' set but not used [-Wunused-but-set-variable]
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:2996:25:
>  warning: variable 'tx_desc_info' set but not used [-Wunused-but-set-variable]
> 
> 'cur_rings, max_hw_rings' never used since introduction in commit
> 34e8c406fda5 ("qlcnic: refactor Tx/SDS ring calculation and validation in driver.")
> 'tx_desc_info' never used since commit
> 95b3890ae39f ("qlcnic: Enhance Tx timeout debugging.")
> Also 'queue_type' only can be QLCNIC_RX_QUEUE/QLCNIC_TX_QUEUE,
> so make a trival cleanup on if statement.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied.