linux-kernel - Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 3 Dec 2018 21:17:49 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     Ayman Bagabas <ayman.bagabas@...il.com>,
        ALSA Development Mailing List <alsa-devel@...a-project.org>,
        Hui Wang <hui.wang@...onical.com>,
        Andy Shevchenko <andy@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Kailang Yang <kailang@...ltek.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

On Mon, Dec 3, 2018 at 9:04 PM Takashi Iwai <tiwai@...e.de> wrote:
>
> On Mon, 03 Dec 2018 19:53:39 +0100,
> Ayman Bagabas wrote:
> > +     if (code == 0x80) {
> > +             acpi_status status;
> > +             acpi_handle handle;
> > +             unsigned long long result;
> > +             union acpi_object args[1];
> > +             struct acpi_object_list arg_list = {
> > +                     .pointer = args,
> > +                     .count = ARRAY_SIZE(args),
> > +             };
> > +
> > +             args[0].type = ACPI_TYPE_INTEGER;
> > +             args[0].integer.value = 0;
> > +
> > +             status = acpi_get_handle(NULL, "\\WMI0", &handle);
> > +             if (ACPI_FAILURE(status)) {
> > +                     dev_err(&wdev->dev, "Unable to get ACPI handle\n");
> > +                     return;
> > +             }
> > +
> > +             status = acpi_evaluate_integer(NULL, "WQ00", &arg_list, &result);
>
> I guess you need to pass handle here?  In the earlier version, you
> passed \\WMI0.WQ00, so it worked with NULL handle.  But now it's no
> longer so...

I think in this case we don't need to have a separate call to get
handle and try to get integer directly. In either we will have an
error case if method  / namespace / etc is not found.

> Other than that, it looks OK to me.
>   Reviewed-by: Takashi Iwai <tiwai@...e.de>
>
> But, you don't need to rush too much.  Instead, better to test your
> own patches and make sure that they really work before submitting the
> final version.

Yes, I will wait couple of days for v10 in hope it will be tested carefully.

-- 
With Best Regards,
Andy Shevchenko