linux-kernel - [PATCH] component: do not stop components lookup after first fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 06 Dec 2018 15:11:47 +0100
From:   Andrzej Hajda <a.hajda@...sung.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Andrzej Hajda <a.hajda@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        linux-kernel@...r.kernel.org,
        Russell King - ARM Linux <linux@...linux.org.uk>
Subject: [PATCH] component: do not stop components lookup after first fail

Currently showing content of /sys/kernel/debug/device_component/*
works partially, in case one of the components is not available this and
all remaining components have status not-registered, but the problem
is only with the first one.
Allowing to finish lookup for other components in case one is missing
solves the issue.

Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>
---
 drivers/base/component.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/component.c b/drivers/base/component.c
index e8d676fad0c9..e9572b37d5cf 100644
--- a/drivers/base/component.c
+++ b/drivers/base/component.c
@@ -179,7 +179,7 @@ static int find_components(struct master *master)
 		c = find_component(master, mc->compare, mc->data);
 		if (!c) {
 			ret = -ENXIO;
-			break;
+			continue;
 		}
 
 		dev_dbg(master->dev, "found component %s, duplicate %u\n", dev_name(c->dev), !!c->master);
-- 
2.17.1