linux-kernel - Re: [PATCH] media: Kconfig: Add configuration entry for MEDIA_MEM2MEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Dec 2018 02:15:37 +0000
From:   Priit Laes <plaes@...es.org>
To:     Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: Kconfig: Add configuration entry for
 MEDIA_MEM2MEM_SUPPORT

On Wed, Dec 05, 2018 at 05:47:03PM -0200, Mauro Carvalho Chehab wrote:
> Em Mon, 26 Nov 2018 18:38:44 +0200
> Priit Laes <plaes@...es.org> escreveu:
> 
> > Currently there is no easy way to enable mem2mem based video
> > processor drivers (cedrus for example). Simplify this by adding
> > separate category to media support.
> > 
> > Signed-off-by: Priit Laes <plaes@...es.org>
> > ---
> >  drivers/media/Kconfig | 12 ++++++++++--
> >  1 file changed, 10 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> > index 8add62a18293..f2a773896dcf 100644
> > --- a/drivers/media/Kconfig
> > +++ b/drivers/media/Kconfig
> > @@ -56,6 +56,14 @@ config MEDIA_DIGITAL_TV_SUPPORT
> >  	  Say Y when you have a board with digital support or a board with
> >  	  hybrid digital TV and analog TV.
> >  
> > +config MEDIA_MEM2MEM_SUPPORT
> > +    bool "Mem2mem devices (stateless media decoders/encoders support)"
> > +    ---help---
> > +	  Enable support for mem2mem / stateless media decoders/encoders.
> > +
> > +	  Say Y when you have a system with stateless media encoder/decoder
> > +	  support.
> > +
> >  config MEDIA_RADIO_SUPPORT
> >  	bool "AM/FM radio receivers/transmitters support"
> >  	---help---
> > @@ -95,7 +103,7 @@ source "drivers/media/cec/Kconfig"
> >  
> >  config MEDIA_CONTROLLER
> >  	bool "Media Controller API"
> > -	depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT
> > +	depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT || MEDIA_MEM2MEM_SUPPORT
> >  	---help---
> >  	  Enable the media controller API used to query media devices internal
> >  	  topology and configure it dynamically.
> > @@ -118,7 +126,7 @@ config MEDIA_CONTROLLER_DVB
> >  config VIDEO_DEV
> >  	tristate
> >  	depends on MEDIA_SUPPORT
> > -	depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT
> > +	depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT || MEDIA_MEM2MEM_SUPPORT
> >  	default y
> >  
> >  config VIDEO_V4L2_SUBDEV_API
> 
> Hmm... this patch looks incomplete. I mean, the main goal of those
> MEDIA_*_SUPPORT is to make simpler for the users to select a
> subset of the drivers. Those options actually make visible
> the corresponding entries for pci/usb/... drivers. So,
> for example, drivers/media/usb/Kconfig contains:
> 
> 	if MEDIA_CAMERA_SUPPORT
> 		comment "Webcam devices"
> 	source "drivers/media/usb/uvc/Kconfig"
> 	source "drivers/media/usb/gspca/Kconfig"
> 	source "drivers/media/usb/pwc/Kconfig"
> 	source "drivers/media/usb/cpia2/Kconfig"
> 	source "drivers/media/usb/zr364xx/Kconfig"
> 	source "drivers/media/usb/stkwebcam/Kconfig"
> 	source "drivers/media/usb/s2255/Kconfig"
> 	source "drivers/media/usb/usbtv/Kconfig"
> 	endif
> 
> If we'll be adding it, I would expect a corresponding change at
> drivers/media/platform/Kconfig.

Thanks, I will look into it. The current approach at least made it
somewhat easier to enable sunxi-cedrus via menuconfig.
> 
> Thanks,
> Mauro