linux-kernel - Re: [PATCH v1 2/4] arm64: dts: qcom: msm8996: Fix QMP PHY #clock-cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Dec 2018 14:02:06 +0530
From:   Vivek Gautam <vivek.gautam@...eaurora.org>
To:     evgreen@...omium.org
Cc:     kishon <kishon@...com>, "robh+dt" <robh+dt@...nel.org>,
        Andy Gross <andy.gross@...aro.org>,
        Doug Anderson <dianders@...omium.org>, swboyd@...omium.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        David Brown <david.brown@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@...r.kernel.org>
Subject: Re: [PATCH v1 2/4] arm64: dts: qcom: msm8996: Fix QMP PHY #clock-cells

On Fri, Nov 30, 2018 at 3:45 AM Evan Green <evgreen@...omium.org> wrote:
>
> Move #clock-cells into the child node and set it to 0 to conform to the
> proper binding specification.
>
> Signed-off-by: Evan Green <evgreen@...omium.org>
> ---
>
>  arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 13bb96444df00..4af740ca0880f 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -767,7 +767,6 @@
>                 phy@...00 {
>                         compatible = "qcom,msm8996-qmp-pcie-phy";
>                         reg = <0x34000 0x488>;
> -                       #clock-cells = <1>;
>                         #address-cells = <1>;
>                         #size-cells = <1>;
>                         ranges;
> @@ -790,6 +789,7 @@
>                                 reg = <0x035000 0x130>,
>                                         <0x035200 0x200>,
>                                         <0x035400 0x1dc>;
> +                               #clock-cells = <0>;
>                                 #phy-cells = <0>;
>
>                                 clock-output-names = "pcie_0_pipe_clk_src";
> @@ -803,6 +803,7 @@
>                                 reg = <0x036000 0x130>,
>                                         <0x036200 0x200>,
>                                         <0x036400 0x1dc>;
> +                               #clock-cells = <0>;
>                                 #phy-cells = <0>;
>
>                                 clock-output-names = "pcie_1_pipe_clk_src";
> @@ -816,6 +817,7 @@
>                                 reg = <0x037000 0x130>,
>                                         <0x037200 0x200>,
>                                         <0x037400 0x1dc>;
> +                               #clock-cells = <0>;
>                                 #phy-cells = <0>;
>
>                                 clock-output-names = "pcie_2_pipe_clk_src";
> @@ -829,7 +831,6 @@
>                 phy@...0000 {
>                         compatible = "qcom,msm8996-qmp-usb3-phy";
>                         reg = <0x7410000 0x1c4>;
> -                       #clock-cells = <1>;
>                         #address-cells = <1>;
>                         #size-cells = <1>;
>                         ranges;
> @@ -851,6 +852,7 @@
>                                 reg = <0x7410200 0x200>,
>                                         <0x7410400 0x130>,
>                                         <0x7410600 0x1a8>;
> +                               #clock-cells = <0>;
>                                 #phy-cells = <0>;
>
>                                 clock-output-names = "usb3_phy_pipe_clk_src";
> --
> 2.18.1
>

Tested on db820c [1]
Tested-by: Vivek Gautam <vivek.gautam@...eaurora.org>

[1] https://github.com/vivekgautam1/linux/tree/origin/v4.20-rc5/db820c

BRs
Vivek

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation