linux-kernel - Re: [PATCH 3/8] Input: tm2-touchkey: Use predefined device name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 8 Dec 2018 20:23:38 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>
Cc:     robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, xc-racer2@...e.ca,
        simon@...eageos.org
Subject: Re: [PATCH 3/8] Input: tm2-touchkey: Use predefined device name

On Fri, Dec 07, 2018 at 11:58:06AM +0100, Paweł Chmiel wrote:
> From: Jonathan Bakker <xc-racer2@...e.ca>
> 
> Purely a cosmetic fix, using the names defined earlier

If we decide to keep different names please fold into first patch.

> 
> Signed-off-by: Jonathan Bakker <xc-racer2@...e.ca>
> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>
> ---
>  drivers/input/keyboard/tm2-touchkey.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/keyboard/tm2-touchkey.c b/drivers/input/keyboard/tm2-touchkey.c
> index 37a5ced24009..cc713b901bf2 100644
> --- a/drivers/input/keyboard/tm2-touchkey.c
> +++ b/drivers/input/keyboard/tm2-touchkey.c
> @@ -57,13 +57,13 @@ struct tm2_touchkey_data {
>  };
>  
>  static struct touchkey_variant tm2_touchkey_variant = {
> -	.name = "tm2-touchkey",
> +	.name = TM2_TOUCHKEY_DEV_NAME,
>  	.keycode_reg = 0x03,
>  	.base_reg = 0x00,
>  };
>  
>  static struct touchkey_variant midas_touchkey_variant = {
> -	.name = "midas-touchkey",
> +	.name = MIDAS_TOUCHKEY_DEV_NAME,
>  	.keycode_reg = 0x00,
>  	.base_reg = 0x00,
>  };
> -- 
> 2.17.1
> 

-- 
Dmitry