linux-kernel - Re: [PATCH] pinctrl: msm: mark PM functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Dec 2018 13:26:14 -0800
From:   Evan Green <evgreen@...omium.org>
To:     arnd@...db.de
Cc:     bjorn.andersson@...aro.org, linus.walleij@...aro.org,
        swboyd@...omium.org, timur@...eaurora.org, dianders@...omium.org,
        ricardo.ribalda@...il.com, linux-arm-msm@...r.kernel.org,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: msm: mark PM functions as __maybe_unused

On Mon, Dec 10, 2018 at 1:00 PM Arnd Bergmann <arnd@...db.de> wrote:
>
> Without CONFIG_PM_SLEEP, we get annoyting warnings about unused functions:
>
> drivers/pinctrl/qcom/pinctrl-msm.c:1082:12: error: 'msm_pinctrl_resume' defined but not used [-Werror=unused-function]
>  static int msm_pinctrl_resume(struct device *dev)
>             ^~~~~~~~~~~~~~~~~~
> drivers/pinctrl/qcom/pinctrl-msm.c:1075:12: error: 'msm_pinctrl_suspend' defined but not used [-Werror=unused-function]
>  static int msm_pinctrl_suspend(struct device *dev)
>
> Mark them as __maybe_unused to shut up the warning and silently drop
> the functions without having to add ugly #ifdefs.
>
> Fixes: 977d057ad346 ("pinctrl: msm: Add sleep pinctrl state transitions")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/pinctrl/qcom/pinctrl-msm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 87cbebe217fd..ee8119879c4c 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -1072,14 +1072,14 @@ static void msm_pinctrl_setup_pm_reset(struct msm_pinctrl *pctrl)
>                 }
>  }
>
> -static int msm_pinctrl_suspend(struct device *dev)
> +static __maybe_unused int msm_pinctrl_suspend(struct device *dev)
>  {
>         struct msm_pinctrl *pctrl = dev_get_drvdata(dev);
>
>         return pinctrl_force_sleep(pctrl->pctrl);
>  }
>
> -static int msm_pinctrl_resume(struct device *dev)
> +static __maybe_unused int msm_pinctrl_resume(struct device *dev)
>  {
>         struct msm_pinctrl *pctrl = dev_get_drvdata(dev);
>

Thanks Arnd.

Reviewed-by: Evan Green <evgreen@...omium.org>