linux-kernel - Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Dec 2018 18:51:56 +0000
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Baruch Siach <baruch@...s.co.il>
Cc:     Antoine Tenart <antoine.tenart@...tlin.com>, davem@...emloft.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        thomas.petazzoni@...tlin.com, maxime.chevallier@...tlin.com,
        gregory.clement@...tlin.com, miquel.raynal@...tlin.com,
        nadavh@...vell.com, stefanc@...vell.com, ymarkman@...vell.com,
        mw@...ihalf.com
Subject: Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

On Tue, Dec 11, 2018 at 07:53:42PM +0200, Baruch Siach wrote:
> That is, something like this, right?
> 
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> index 125ea99418df..04cb0241ca2b 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> @@ -4404,13 +4404,18 @@ static void mvpp2_phylink_validate(struct net_device *dev,
>  	switch (state->interface) {
>  	case PHY_INTERFACE_MODE_10GKR:
>  	case PHY_INTERFACE_MODE_XAUI:
> +		if (port->gop_id != 0)
> +			goto empty_set;
> +		/* Fall-through */
>  	case PHY_INTERFACE_MODE_NA:
> -		phylink_set(mask, 10000baseCR_Full);
> -		phylink_set(mask, 10000baseSR_Full);
> -		phylink_set(mask, 10000baseLR_Full);
> -		phylink_set(mask, 10000baseLRM_Full);
> -		phylink_set(mask, 10000baseER_Full);
> -		phylink_set(mask, 10000baseKR_Full);
> +		if (port->gop_id == 0) {
> +			phylink_set(mask, 10000baseCR_Full);
> +			phylink_set(mask, 10000baseSR_Full);
> +			phylink_set(mask, 10000baseLR_Full);
> +			phylink_set(mask, 10000baseLRM_Full);
> +			phylink_set(mask, 10000baseER_Full);
> +			phylink_set(mask, 10000baseKR_Full);
> +		}
>  		/* Fall-through */
>  	case PHY_INTERFACE_MODE_RGMII:
>  	case PHY_INTERFACE_MODE_RGMII_ID:
> 

Yep, looks fine to me, thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up