linux-kernel - Re: [PATCH -next] i5000_edac: remove set but not used variables 'maxdimmperch, maxch, channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 11 Dec 2018 14:58:29 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     mchehab@...nel.org, linux-kernel@...r.kernel.org,
        linux-edac@...r.kernel.org
Subject: Re: [PATCH -next] i5000_edac: remove set but not used variables
 'maxdimmperch, maxch, channel_count'

On Tue, Dec 11, 2018 at 05:52:07PM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/edac/i5000_edac.c: In function 'i5000_get_mc_regs':
> drivers/edac/i5000_edac.c:1138:6: warning:
>  variable 'maxdimmperch' set but not used [-Wunused-but-set-variable]
> 
> drivers/edac/i5000_edac.c:1137:6: warning:
>  variable 'maxch' set but not used [-Wunused-but-set-variable]
> 
> drivers/edac/i5000_edac.c: In function 'i5000_init_csrows':
> drivers/edac/i5000_edac.c:1256:13: warning:
>  variable 'channel_count' set but not used [-Wunused-but-set-variable]
> 
> It never used since introduction in
> commit eb60705ac5a9 ("drivers/edac: new intel 5000 MC driver")
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/edac/i5000_edac.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.