linux-kernel - Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Dec 2018 22:28:35 +0000
From:   Paul Burton <paul.burton@...s.com>
To:     Firoz Khan <firoz.khan@...aro.org>
CC:     "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        James Hogan <jhogan@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux-Arch <linux-arch@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        Marcin Juszkiewicz <marcin.juszkiewicz@...aro.org>
Subject: Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

Hi Firoz,

On Wed, Dec 12, 2018 at 10:04:47AM +0530, Firoz Khan wrote:
> > > Will this below change will help?
> > >
> > >  #define _MIPS_SIM_ABI32              1
> > >  #define _MIPS_SIM_NABI32            2
> > >  #define _MIPS_SIM_ABI64              3
> > > +#define _MIPS_SIM_ABIN64           _MIPS_SIM_ABI64
> >
> > Hmm, I think I'd prefer that we just keep using _MIPS_SIM_ABI64.
> 
> Sure, I think '64' to 'n64' conversion must be remove it from this patch
> series.I can send v5 without '64' to 'n64' conversion.
> 
> If we rename '64' to 'n64' in half of the place and this _MIPS_SIM_ABI64
> if we half to keep it in same looks not good (according to me).
> 
> (FYI, This macro name - _MIPS_SIM_ABIN64 must be _MIPS_SIM_NABI64
> and defintion will be:
> +#define _MIPS_SIM_NABI64           _MIPS_SIM_ABI64)
> 
> So If you confirm I can send v5 without '64' to 'n64' conversion (not just above
> one, completely from this patch series). Or uou can take a call just
> keep this macro -
> _MIPS_SIM_ABI64 as it is and change it rest of the place.

Let's just go ahead & leave everything as 64, and I'll do the 64 -> n64
rename later. I hoped whilst you were adding n64-specific code this
would be an easy change, but at this point let's just prioritize getting
the series applied without the naming change so it can sit in -next for
a while before the merge window.

Thanks,
    Paul