linux-kernel - RE: [PATCH 1/2] block: add bi_crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Dec 2018 05:34:39 +0000
From:   Parshuram Raju Thombare <pthombar@...ence.com>
To:     Jens Axboe <axboe@...nel.dk>, "tj@...nel.org" <tj@...nel.org>,
        "jbacik@...com" <jbacik@...com>,
        "michaelcallahan@...com" <michaelcallahan@...com>,
        "snitzer@...hat.com" <snitzer@...hat.com>,
        "osandov@...com" <osandov@...com>,
        "keith.busch@...el.com" <keith.busch@...el.com>,
        "ming.lei@...hat.com" <ming.lei@...hat.com>,
        "shli@...com" <shli@...com>,
        "dennisszhou@...il.com" <dennisszhou@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Alan Douglas <adouglas@...ence.com>,
        Janek Kotas <jank@...ence.com>,
        Rafal Ciepiela <rafalc@...ence.com>
Subject: RE: [PATCH 1/2] block: add bi_crypto_ctx variable in struct bio

Hello Jens,

Thank you for a comment.

>-----Original Message-----
>From: Jens Axboe <axboe@...nel.dk>
>Sent: Tuesday, December 11, 2018 7:07 PM
>To: Parshuram Raju Thombare <pthombar@...ence.com>; tj@...nel.org;
>jbacik@...com; michaelcallahan@...com; snitzer@...hat.com;
>osandov@...com; keith.busch@...el.com; ming.lei@...hat.com; shli@...com;
>dennisszhou@...il.com; linux-kernel@...r.kernel.org
>Cc: Alan Douglas <adouglas@...ence.com>; Janek Kotas <jank@...ence.com>;
>Rafal Ciepiela <rafalc@...ence.com>
>Subject: Re: [PATCH 1/2] block: add bi_crypto_ctx variable in struct bio
>
>EXTERNAL MAIL
>
>
>On 12/11/18 2:50 AM, Parshuram Thombare wrote:
>> Add variable 'void *bi_crypt_ctx' in 'struct bio'. This will be used
>> to associate bio with crypto configuration of controller supporting
>> real time / inline encryption/decryption.
>>
>> Signed-off-by: Parshuram Thombare <pthombar@...ence.com>
>> ---
>>  include/linux/blk_types.h |    4 ++++
>>  1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
>> index 1dcf652..bd77603 100644
>> --- a/include/linux/blk_types.h
>> +++ b/include/linux/blk_types.h
>> @@ -188,6 +188,10 @@ struct bio {
>>  #endif
>>  	};
>>
>> +#ifdef CONFIG_BLK_DEV_HW_RT_ENCRYPTION
>> +	void *bi_crypto_ctx;
>> +#endif
>> +
>>  	unsigned short		bi_vcnt;	/* how many bio_vec's */
>>
>>  	/*
>
>Pretty sure I mentioned this last time, but in case I didn't, don't add bio members
>for random drivers. Can you imagine how huge this thing would be if we allowed
>that?
>
>If you need per-io storage, put it in the payload for the blk-mq request. That way
>you are only bloating your own IO related data structures, not everyones.
Ok, I will look into using payload for the blk-mq request instead of adding variable 
in struct bio.
I thought this filed would be useful in enabling inline encryption for other type of
devices too.
>
>--
>Jens Axboe

Regards,
Parshuram Thombare