linux-kernel - Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power supply name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Dec 2018 09:19:57 -0200
From:   Fabio Estevam <festevam@...il.com>
To:     Yongcai Huang <anson.huang@....com>
Cc:     Rob Herring <robh@...nel.org>, Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald <pmeerw@...erw.net>,
        Mark Rutland <mark.rutland@....com>, linux-iio@...r.kernel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        NXP Linux Team <linux-imx@....com>
Subject: Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power
 supply name

Hi Anson,

On Wed, Dec 12, 2018 at 4:17 AM Anson Huang <anson.huang@....com> wrote:
>
> Hi, Fabio
>         Obviously, some of the dts files (such as arch/arm/boot/dts/exynos5420-peach-pit.dts) using "vcc" as isl29018's power supply name, they are NOT matched with datasheet, so should we update those dts files with "vdd" as well or just using the "vcc" in isl29018 driver? Which solution is better?

We should not break existing dtbs, so in this case just keep the
existing supply name and you could add the new optional vdda supply as
per the datasheet.