linux-kernel - RE: [PATCH] dt-bindings: PCI: rcar: Add device tree support for r8a774c0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 14 Dec 2018 10:49:16 +0000
From:   Fabrizio Castro <fabrizio.castro@...renesas.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
CC:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        linux-pci <linux-pci@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Simon Horman <horms@...ge.net.au>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH] dt-bindings: PCI: rcar: Add device tree support for
 r8a774c0

Hello Geert,

Thank you for your feedback!

> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Sent: 14 December 2018 10:29
> Subject: Re: [PATCH] dt-bindings: PCI: rcar: Add device tree support for r8a774c0
>
> Hi Fabrizio,
>
> On Thu, Dec 13, 2018 at 9:21 PM Fabrizio Castro
> <fabrizio.castro@...renesas.com> wrote:
> > Add PCIe support for the RZ/G2E (a.k.a. R8A774C0).
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@...renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
>
> One question below.
>
> > --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt
> > +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt
>
> > @@ -37,7 +39,8 @@ compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC;
> >
> >  Optional properties:
> >  - phys: from common PHY binding: PHY phandle and specifier (only make sense
> > -       for R-Car gen3 SoCs where the PCIe PHYs have their own register blocks).
> > +       for R-Car gen3 and RZ/G2 SoCs where the PCIe PHYs have their own
>
> Gen3, while at it?

Can do

>
> > +       register blocks).
>
> The RZ/G2 Hardware User Manual I have lacks the table specifying which SoCs
> have which PHY registers.  So I cannot verify if the above paragraph applies to
> RZ/G2(E).

I'll reply to this on your follow-up  email.

Thanks,
Fab

>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds


[https://www2.renesas.eu/media/email/unicef.jpg]

This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.