linux-kernel - Re: [PATCH v14 2/5] x86/boot: Introduce efi_get_rsdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Dec 2018 19:49:29 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Chao Fan <fanc.fnst@...fujitsu.com>, linux-kernel@...r.kernel.org,
        x86@...nel.org, bp@...en8.de, mingo@...hat.com, hpa@...or.com,
        keescook@...omium.org, bhe@...hat.com, msys.mizuma@...il.com,
        indou.takao@...fujitsu.com, caoj.fnst@...fujitsu.com
Subject: Re: [PATCH v14 2/5] x86/boot: Introduce efi_get_rsdp_addr() to find
 RSDP from EFI table


* Thomas Gleixner <tglx@...utronix.de> wrote:

> On Mon, 17 Dec 2018, Ingo Molnar wrote:
> > * Chao Fan <fanc.fnst@...fujitsu.com> wrote:
> > > +		else if (!(efi_guidcmp(guid, ACPI_20_TABLE_GUID)))
> > > +			return (acpi_physical_address)table;
> > 
> > 'return' is not a function.
> 
> It's still a typecast :)

Yeah, see my followup from an hour ago:

  Message-ID: <20181217173605.GA14613@...il.com>

Thanks,

	Ingo