linux-kernel - Re: [PATCH] m68k/mac: Use '030 reset method on SE/30

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 23 Dec 2018 10:03:27 +1100 (AEDT)
From:   Finn Thain <fthain@...egraphics.com.au>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
cc:     Joshua Thompson <funaho@...ai.org>,
        linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] m68k/mac: Use '030 reset method on SE/30

On Sat, 22 Dec 2018, Geert Uytterhoeven wrote:

> > -                       local_irq_save(flags);
> > -
> > -                       rom_reset();
> > -
> > -                       local_irq_restore(flags);
> 
> I guess you removed the call to local_irq_restore() because you never
> get there anyway?
> 

If a ROM call returns, we have a real problem, because we didn't call it 
in an execution environment that it is designed to be called in. Anything 
could happen.

Moreover, local_irq_restore() is bogus either way, given that there's 
nothing that our interrupt handlers can usefully do now.

See also commit 558d5ad276c9 ("m68k/mac: Avoid soft-lockup warning after 
mach_power_off").

--