linux-kernel - Re: [PATCH] media: mt312: fix a missing check of mt312 reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Dec 2018 12:23:28 +0100
From:   Matthias Schwarzott <zzam@...too.org>
To:     Kangjie Lu <kjlu@....edu>
Cc:     pakki001@....edu, Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans Verkuil <hans.verkuil@...co.com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: mt312: fix a missing check of mt312 reset

Am 21.12.18 um 08:07 schrieb Kangjie Lu:
> mt312_reset() may fail. Although it is called in the end of
> mt312_set_frontend(), we better check its status and return its error
> code upstream instead of 0.
> 
> Signed-off-by: Kangjie Lu <kjlu@....edu>

Thanks for submitting this patch. It looks correct.

Reviewed-by: Matthias Schwarzott <zzam@...too.org>

> ---
>  drivers/media/dvb-frontends/mt312.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/dvb-frontends/mt312.c b/drivers/media/dvb-frontends/mt312.c
> index 03e74a729168..bfbb879469f2 100644
> --- a/drivers/media/dvb-frontends/mt312.c
> +++ b/drivers/media/dvb-frontends/mt312.c
> @@ -645,7 +645,9 @@ static int mt312_set_frontend(struct dvb_frontend *fe)
>  	if (ret < 0)
>  		return ret;
>  
> -	mt312_reset(state, 0);
> +	ret = mt312_reset(state, 0);
> +	if (ret < 0)
> +		return ret;
>  
>  	return 0;
>  }
>