linux-kernel - Re: [PATCH 1/6] ARM: dts: s5pv210: Use correct fimd variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Dec 2018 12:37:28 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>
Cc:     kgene@...nel.org, robh+dt@...nel.org, mark.rutland@....com,
        linux@...linux.org.uk, xc-racer2@...e.ca,
        linux-arm-kernel@...ts.infradead.org,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] ARM: dts: s5pv210: Use correct fimd variant

On Fri, 28 Dec 2018 at 17:18, Paweł Chmiel
<pawel.mikolaj.chmiel@...il.com> wrote:
>
> Since we have separate compatible for our SOC,
> let's use it rather using one from exynos4210.

Please fix
your editor
to wrap lines
matching Linux
style because
it is difficult
to read.

You have unusual configuration because most of the editors wrap git
commit as expected.
https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L633

Best regards,
Krzysztof

>
> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>
> ---
>  arch/arm/boot/dts/s5pv210.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
> index 75f454a210d6..3d6e5ad1ea35 100644
> --- a/arch/arm/boot/dts/s5pv210.dtsi
> +++ b/arch/arm/boot/dts/s5pv210.dtsi
> @@ -511,7 +511,7 @@
>                 };
>
>                 fimd: fimd@...00000 {
> -                       compatible = "samsung,exynos4210-fimd";
> +                       compatible = "samsung,s5pv210-fimd";
>                         interrupt-parent = <&vic2>;
>                         reg = <0xf8000000 0x20000>;
>                         interrupt-names = "fifo", "vsync", "lcd_sys";
> --
> 2.17.1
>