linux-kernel - [PATCH 06/14] clocksource/drivers/c-sky: fixup qemu fail to bootup sometimes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Dec 2018 23:27:03 +0800
From:   guoren@...nel.org
To:     daniel.lezcano@...aro.org, tglx@...utronix.de
Cc:     guoren@...nel.org, linux-kernel@...r.kernel.org,
        Guo Ren <ren_guo@...ky.com>
Subject: [PATCH 06/14] clocksource/drivers/c-sky: fixup qemu fail to bootup sometimes.

From: Guo Ren <ren_guo@...ky.com>

Timer startup must after timer_irq_enable. For qemu, timer tick
irq hanppens but irq not enable, so it will cause qemu boot failed.

Signed-off-by: Guo Ren <ren_guo@...ky.com>
Tested-by: Liu Zhiwei <zhiwei_liu@...ky.com>
---
 drivers/clocksource/timer-mp-csky.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clocksource/timer-mp-csky.c b/drivers/clocksource/timer-mp-csky.c
index a8acc43..3cb6dbc 100644
--- a/drivers/clocksource/timer-mp-csky.c
+++ b/drivers/clocksource/timer-mp-csky.c
@@ -79,11 +79,11 @@ static int csky_mptimer_starting_cpu(unsigned int cpu)
 
 	to->clkevt.cpumask = cpumask_of(cpu);
 
+	enable_percpu_irq(csky_mptimer_irq, 0);
+
 	clockevents_config_and_register(&to->clkevt, timer_of_rate(to),
 					2, ULONG_MAX);
 
-	enable_percpu_irq(csky_mptimer_irq, 0);
-
 	return 0;
 }
 
-- 
2.7.4