linux-kernel - Re: [PATCH v4 4/4] hwrng: add OP-TEE based rng driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Jan 2019 11:43:14 +0100
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Sumit Garg <sumit.garg@...aro.org>,
        Jens Wiklander <jens.wiklander@...aro.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        mpm@...enic.com, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Bhupesh Sharma <bhsharma@...hat.com>, tee-dev@...ts.linaro.org
Subject: Re: [PATCH v4 4/4] hwrng: add OP-TEE based rng driver

On Mon, 21 Jan 2019 at 11:30, Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Mon, Jan 21, 2019 at 02:59:19PM +0530, Sumit Garg wrote:
> > --- /dev/null
> > +++ b/drivers/char/hw_random/optee-rng.c
> > @@ -0,0 +1,272 @@
> > +// SPDX-License-Identifier: GPL-2.0
>
> Nice, but:
>
> <snip>
>
> > +MODULE_LICENSE("GPL");
>
> This string means "GPL2+", you need "GPLv2" here instead.
>

I think you need a space there: "GPL v2" or it doesn't get picked up
correctly (or at least, it didn't use to)

> Yeah, it's a pain, and everyone gets it wrong, we need to add a
> checkpatch.pl rule for this to keep it from being added in new code.
>
> thanks,
>
> greg k-h