linux-kernel - Re: [PATCH] 8250_pci.c: Update NI specific devices class to multi serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 25 Jan 2019 00:47:43 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "KHUENY.Gerhard" <Gerhard.KHUENY@...hmann.info>
Cc:     Guan Yung Tseng <guan.yung.tseng@...com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] 8250_pci.c: Update NI specific devices class to multi serial

On Thu, Jan 24, 2019 at 1:15 PM KHUENY.Gerhard
<Gerhard.KHUENY@...hmann.info> wrote:
>
> Hi,
>
> I would appreciate this change since this would solve my problem also ;-)
>

I have sent couple of hours ago the patch to upstream. If I'm not
mistaken, you did test it and I put deliberatly your tag. Tell me if
it's not the case or, if you have a chance, test it.

> Best regards,
> Gerhard Khüny
>
> -----Ursprüngliche Nachricht-----
> Von: linux-serial-owner@...r.kernel.org <linux-serial-owner@...r.kernel.org> Im Auftrag von Andy Shevchenko
> Gesendet: Mittwoch, 23. Jänner 2019 17:07
> An: Guan Yung Tseng <guan.yung.tseng@...com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>; open list:SERIAL DRIVERS <linux-serial@...r.kernel.org>; Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
> Betreff: Re: [PATCH] 8250_pci.c: Update NI specific devices class to multi serial
>
> On Wed, Jan 23, 2019 at 5:18 PM Andy Shevchenko <andy.shevchenko@...il.com> wrote:
> >
> > On Mon, Jan 14, 2019 at 4:13 PM Guan Yung Tseng <guan.yung.tseng@...com> wrote:
> > >
> > > Modified NI devices class to PCI_CLASS_COMMUNICATION_MULTISERIAL.
> > > The reason of doing this is because all NI multi port serial cards
> > > use PCI_CLASS_COMMUNICATION_OTHER class and thus fail the
> > > serial_pci_is_class_communication test added in the commit
> > > 7d8905d06405
> > > ("serial: 8250_pci: Enable device after we check black list").
> >
> > Guan, can you provide an output of the
> >
> > lspci -nk -xx -vv -s <BDF>
> >
> > of your device, where <BDF> is a PCI address in a form of bus:device.function?
>
> While I'm still wondering of the above, can you also test the bellow patch if it fixes your issue?
>
>
>
>
> --
> With Best Regards,
> Andy Shevchenko



-- 
With Best Regards,
Andy Shevchenko