linux-kernel - Re: [PATCH V4 0/6] add pvpanic driver framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 24 Jan 2019 16:00:03 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Peng Hao <peng.hao2@....com.cn>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V4 0/6] add pvpanic driver framework

On Thu, Jan 24, 2019 at 10:17 AM Peng Hao <peng.hao2@....com.cn> wrote:
>
> QEMU community requires additional PCI devices to simulate PVPANIC
> devices so that some architectures can not occupy precious less than 4G
> of memory space.
> Previously, I added PCI driver directly to the original version of the driver,
> which made the whole driver file look a bit cluttered. So Andy Shevchenko suggests:
> "I would recommend to split it in a way how it's done for ChipIdea USB driver,
> for example. (drivers/usb/chipidea if I'm not mistaken)".
>

Thank you for an update.

The series has the bisectability issues.

Try to use the following approach (if I got your idea right):
1. Convert to use common probe() etc functions inplace
2. Split ACPI part
3. Split OF part
4. Add PCI part

In Kconfig and Makefile follow the example like present under
drivers/usb/chipidea/.

> v3 ---> v4 : add help text info in Konfig from patch_0004 to
>               patch_0006
>              adjust structure definition position in patch_0002
>               and patch_0003
> v2 ---> v3 : add change infomation.
>
> v1 ---> v2 : add patch 0000 to descript the whole patch series.
>              modify text infomation from patch_0002 to patch_0006.
>              modify "SPDX-License-Identifier: GPL-2.0-or-later"
>                  to "SPDX-License-Identifier: GPL-2.0+"
>
> Peng Hao (6):
>   misc/pvpanic: preparing for pvpanic driver framework
>   misc/pvpanic: Add pvpanic driver framework
>   misc/pvpanic: add API for pvpanic driver framework
>   misc/pvpanic: add pvpanic acpi driver
>   misc/pvpanic: add pvpanic mmio driver
>   misc/pvpanic: add new pvpanic pci driver
>
>  drivers/misc/Kconfig                |   9 +-
>  drivers/misc/Makefile               |   2 +-
>  drivers/misc/pvpanic.c              | 192 ------------------------------------
>  drivers/misc/pvpanic/Kconfig        |  34 ++++++
>  drivers/misc/pvpanic/Makefile       |   8 ++
>  drivers/misc/pvpanic/pvpanic-acpi.c |  77 +++++++++++++++
>  drivers/misc/pvpanic/pvpanic-of.c   |  53 ++++++++++
>  drivers/misc/pvpanic/pvpanic-pci.c  |  56 +++++++++++
>  drivers/misc/pvpanic/pvpanic.c      | 131 ++++++++++++++++++++++++
>  drivers/misc/pvpanic/pvpanic.h      |  14 +++
>  10 files changed, 366 insertions(+), 201 deletions(-)
>  delete mode 100644 drivers/misc/pvpanic.c
>  create mode 100644 drivers/misc/pvpanic/Kconfig
>  create mode 100644 drivers/misc/pvpanic/Makefile
>  create mode 100644 drivers/misc/pvpanic/pvpanic-acpi.c
>  create mode 100644 drivers/misc/pvpanic/pvpanic-of.c
>  create mode 100644 drivers/misc/pvpanic/pvpanic-pci.c
>  create mode 100644 drivers/misc/pvpanic/pvpanic.c
>  create mode 100644 drivers/misc/pvpanic/pvpanic.h
>
> --
> 1.8.3.1
>


-- 
With Best Regards,
Andy Shevchenko