linux-kernel - Re: [PATCH] fpga: mgr: altera-ps-spi: make array dummy static, shrinks object size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 24 Jan 2019 09:22:54 -0800
From:   Moritz Fischer <moritz.fischer@...us.com>
To:     Alan Tull <atull@...nel.org>
Cc:     Colin King <colin.king@...onical.com>, linux-fpga@...r.kernel.org,
        kernel-janitors@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fpga: mgr: altera-ps-spi: make array dummy static,
 shrinks object size

Hi Colin,

sorry dropped of my radar.

On Thu, Jan 24, 2019 at 9:17 AM Alan Tull <atull@...nel.org> wrote:
>
> On Thu, Nov 29, 2018 at 5:10 PM Colin King <colin.king@...onical.com> wrote:
>
> Hi Colin,
>
> Thanks!
>
> >
> > From: Colin Ian King <colin.king@...onical.com>
> >
> > Don't populate the const array dummy on the stack but instead
> > make it static. Makes the object code smaller by 26 bytes:
> >
> > Before:
> >    text    data     bss     dec     hex filename
> >    7371    2032       0    9403    24bb drivers/fpga/altera-ps-spi.o
> >
> > After:
> >    text    data     bss     dec     hex filename
> >    7281    2096       0    9377    24a1 drivers/fpga/altera-ps-spi.o
> >
> > (gcc version 8.2.0 x86_64)
> >
> > Signed-off-by: Colin Ian King <colin.king@...onical.com>
>
> Acked-by: Alan Tull <atull@...nel.org>
Acked-by: Moritz Fischer <mdf@...nel.org>

>
>
> > ---
> >  drivers/fpga/altera-ps-spi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
> > index 8c18beec6b57..678d0115f840 100644
> > --- a/drivers/fpga/altera-ps-spi.c
> > +++ b/drivers/fpga/altera-ps-spi.c
> > @@ -205,7 +205,7 @@ static int altera_ps_write_complete(struct fpga_manager *mgr,
> >                                     struct fpga_image_info *info)
> >  {
> >         struct altera_ps_conf *conf = mgr->priv;
> > -       const char dummy[] = {0};
> > +       static const char dummy[] = {0};
> >         int ret;
> >
> >         if (gpiod_get_value_cansleep(conf->status)) {
> > --
> > 2.19.1
> >

Moritz