linux-kernel - Re: [PATCH] mwifiex: don't advertise IBSS features without FW support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 19 Feb 2019 15:16:07 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Brian Norris <briannorris@...omium.org>
Cc:     Ganapathi Bhat <gbhat@...vell.com>,
        Nishant Sarmukadam <nishants@...vell.com>,
        Amitkumar Karwar <amitkarwar@...il.com>,
        Xinming Hu <huxinming820@...il.com>,
        <linux-kernel@...r.kernel.org>, linux-wireless@...r.kernel.org,
        Karthik D A <karthida@...vell.com>,
        Brian Norris <briannorris@...omium.org>
Subject: Re: [PATCH] mwifiex: don't advertise IBSS features without FW support

Brian Norris <briannorris@...omium.org> wrote:

> As it is, doing something like
> 
>   # iw phy phy0 interface add foobar type ibss
> 
> on a firmware that doesn't have ad-hoc support just yields failures of
> HostCmd_CMD_SET_BSS_MODE, which happened to return a '-1' error code
> (-EPERM? not really right...) and sometimes may even crash the firmware
> along the way.
> 
> Let's parse the firmware capability flag while registering the wiphy, so
> we don't allow attempting IBSS at all, and we get a proper -EOPNOTSUPP
> from nl80211 instead.
> 
> Fixes: e267e71e68ae ("mwifiex: Disable adhoc feature based on firmware capability")
> Signed-off-by: Brian Norris <briannorris@...omium.org>

Patch applied to wireless-drivers-next.git, thanks.

6f21ab30469d mwifiex: don't advertise IBSS features without FW support

-- 
https://patchwork.kernel.org/patch/10814041/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches