linux-kernel - Re: [PATCH -next] ubifs: remove unused function __ubifs_shash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Mar 2019 13:24:55 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Richard Weinberger <richard@....at>
Cc:     Yue Haibing <yuehaibing@...wei.com>, dedekind1@...il.com,
        adrian.hunter@...el.com, linux-kernel@...r.kernel.org,
        linux-mtd@...ts.infradead.org
Subject: Re: [PATCH -next] ubifs: remove unused function __ubifs_shash_final


On 3/21/2019 1:48 AM, Richard Weinberger wrote:
> Am Mittwoch, 20. März 2019, 21:05:37 CET schrieb Mukesh Ojha:
>> On 3/20/2019 7:39 PM, Yue Haibing wrote:
>>> From: YueHaibing <yuehaibing@...wei.com>
>>>
>>> There is no callers in tree, and can be removed.
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>>> ---
>>>    fs/ubifs/auth.c | 18 ------------------
>>>    1 file changed, 18 deletions(-)
>>>
>>> diff --git a/fs/ubifs/auth.c b/fs/ubifs/auth.c
>>> index 5bf5fd0..2a40ccce 100644
>>> --- a/fs/ubifs/auth.c
>>> +++ b/fs/ubifs/auth.c
>>> @@ -147,24 +147,6 @@ struct shash_desc *__ubifs_hash_get_desc(const struct ubifs_info *c)
>>>    }
>>>    
>>>    /**
>>> - * __ubifs_shash_final - finalize shash
>>> - * @c: UBIFS file-system description object
>>> - * @desc: the descriptor
>>> - * @out: the output hash
>>> - *
>>> - * Simple wrapper around crypto_shash_final(), safe to be called with
>>> - * disabled authentication.
>>> - */
>>> -int __ubifs_shash_final(const struct ubifs_info *c, struct shash_desc *desc,
>>> -			u8 *out)
>>> -{
>>> -	if (ubifs_authenticated(c))
>>> -		return crypto_shash_final(desc, out);
>>> -
>>> -	return 0;
>>> -}
>>> -
>>> -/**
>>>     * ubifs_bad_hash - Report hash mismatches
>>>     * @c: UBIFS file-system description object
>>>     * @node: the node
>>
>>
>> Looks fine to be removed.
>>
>> Acked-by: Mukesh Ojha <mojha@...eaurora.org>
> I guess you mean Reviewed-by?

As i am unsure about future scope of this func. i.e why Acked.


-Mukesh



>
> Thanks,
> //richard
>
>
>