linux-kernel - Re: [PATCH] drm: vkms: check status of alloc_ordered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 Mar 2019 09:34:13 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Kangjie Lu <kjlu@....edu>
Cc:     pakki001@....edu, Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>,
        Haneen Mohammed <hamohammed.sa@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: vkms: check status of alloc_ordered_workqueue

On Fri, Mar 22, 2019 at 09:32:07PM -0500, Kangjie Lu wrote:
> 
> 
> > On Mar 8, 2019, at 10:36 PM, Kangjie Lu <kjlu@....edu> wrote:
> > 
> > alloc_ordered_workqueue may fail and return NULL.
> > The fix returns ENOMEM when it fails to avoid potential NULL
> > pointer dereference.
> > 
> > Signed-off-by: Kangjie Lu <kjlu@....edu>
> > ---
> > drivers/gpu/drm/vkms/vkms_crtc.c | 2 ++
> > 1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c
> > index 8a9aeb0a9ea8..bb66dbcd5e3f 100644
> > --- a/drivers/gpu/drm/vkms/vkms_crtc.c
> > +++ b/drivers/gpu/drm/vkms/vkms_crtc.c
> > @@ -219,6 +219,8 @@ int vkms_crtc_init(struct drm_device *dev, struct drm_crtc *crtc,
> > 	spin_lock_init(&vkms_out->state_lock);
> > 
> > 	vkms_out->crc_workq = alloc_ordered_workqueue("vkms_crc_workq", 0);
> > +	if (!vkms_out->crc_workq)
> > +		return -ENOMEM;
> 
> Is this a reasonable patch?

lgtm, applied and thanks for your patch.
-Daniel

> 
> > 
> > 	return ret;
> > }
> > -- 
> > 2.17.1
> > 
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch