linux-kernel - Re: [PATCH v3] RISC-V: Always compile mm/init.c with cmodel=medany and notrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Mar 2019 04:37:48 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Anup Patel <Anup.Patel@....com>
Cc:     Palmer Dabbelt <palmer@...ive.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Christoph Hellwig <hch@...radead.org>,
        Atish Patra <Atish.Patra@....com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH v3] RISC-V: Always compile mm/init.c with cmodel=medany
 and notrace

> +ifdef CONFIG_FTRACE
> +CFLAGS_REMOVE_init.o = -pg
> +endif
> +
>  obj-y += init.o
>  obj-y += fault.o
>  obj-y += extable.o
>  obj-y += ioremap.o
>  obj-y += cacheflush.o
> +
> +CFLAGS_init.o := -mcmodel=medany

Can you keep the two flags adjustments togther, preferably towards
the top of the file?

> +/*
> + * The setup_vm() is called from head.S with MMU-off.

s/The //g

Otherwis looks fine:

Reviewed-by: Christoph Hellwig <hch@....de>