linux-kernel - Re: [PATCH v11 6/8] rtc: bd70528: Initial support for ROHM bd70528 RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 Mar 2019 15:05:52 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mazziesaccount@...il.com" <mazziesaccount@...il.com>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "sre@...nel.org" <sre@...nel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        "Mutanen, Mikko" <Mikko.Mutanen@...rohmeurope.com>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "Haikola, Heikki" <Heikki.Haikola@...rohmeurope.com>
Subject: Re: [PATCH v11 6/8] rtc: bd70528: Initial support for ROHM bd70528
 RTC

On 26/03/2019 13:51:40+0000, Vaittinen, Matti wrote:
> On Mon, 2019-03-25 at 18:04 +0100, Alexandre Belloni wrote:
> > On 25/03/2019 14:06:42+0200, Matti Vaittinen wrote:
> > > Support RTC block in ROHM bd70528 power management IC. Support
> > > getting and setting the time and date as well as arming an alarm
> > > which can also be used to wake the PMIC from standby state.
> > > 
> > > HW supports wake interrupt only for the next 24 hours (sec, minute
> > > and hour information only) so we limit also the alarm interrupt to
> > > this 24 hours for the sake of consistency.
> > > 
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
> > 
> > Acked-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> > 
> > > +	r->time.hour |= BD70528_MASK_RTC_HOUR_24H;
> > > +	r->day |= bin2bcd(t->tm_mday);
> > > +	r->week |= bin2bcd(t->tm_wday);
> > > +	r->month |= bin2bcd(t->tm_mon + 1);
> > > +	r->year = bin2bcd(t->tm_year-100);
> > 
> > If you ever have to resend, please add spaces around that -
> 
> Good catch, thanks! I wonder why I didn't get checkpatch warning... I
> should've had one. (I usually do run checkpatch).
> 

checkpatch --strict would tell you.


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com